Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #171 #172

Merged
merged 1 commit into from Feb 20, 2023
Merged

Fixes #171 #172

merged 1 commit into from Feb 20, 2023

Conversation

ghost
Copy link

@ghost ghost commented Feb 15, 2023

  • Changed func (packets.Properties).Decode to return the total count of Properties bytes
    including VBI header bytes.
  • Updated all invocations of (packets.Properties).Decode to use the changed return value directly.
  • Updated func TestDecodeProperties to check the changed return value

@ghost ghost mentioned this pull request Feb 15, 2023
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4191988197

  • 17 of 17 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 98.55%
Files with Coverage Reduction New Missed Lines %
server.go 2 99.43%
Totals Coverage Status
Change from base Build 4148542410: -0.04%
Covered Lines: 5098
Relevant Lines: 5173
💛 - Coveralls

mochi-co
mochi-co approved these changes Feb 20, 2023
View reviewed changes
Copy link
Collaborator

@mochi-co mochi-co left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - a very elegant solution!
Thank you very much for this @ffa500!

@mochi-co mochi-co merged commit 4c16e55 into mochi-mqtt:master Feb 20, 2023
@wind-c wind-c mentioned this pull request Feb 23, 2023
Closed
@ghost
Copy link
Author

ghost commented Feb 24, 2023

Thanks so much for incorporating the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coveralls @mochi-co