Add Prometheus metrics #184
Conversation
| PacketsSent: atomic.LoadInt64(&i.PacketsSent), | ||
| MemoryAlloc: atomic.LoadInt64(&i.MemoryAlloc), | ||
| Threads: atomic.LoadInt64(&i.Threads), | ||
| // InflightDropped: atomic.LoadInt64(&i.InflightDropped), |
There was a problem hiding this comment.
Is this supposed to be commented?
There was a problem hiding this comment.
I forgot to mention, it appears InflightDropped is not used any more, I can't find any reference where the broker updates it.
| {"c", "messages_dropped", "A counter of total number of publish messages dropped to slow subscriber", &i.MessagesDropped}, | ||
| {"g", "retained", "A gauge of total number of retained messages active on the broker", &i.Retained}, | ||
| {"g", "inflight", "A gauge of the number of messages currently in-flight", &i.Inflight}, | ||
| // {"c", "inflight_dropped", "A", &i.InflightDropped}, |
There was a problem hiding this comment.
same as above, InflightDropped is not updated
|
|
||
| buildInfo := prometheus.NewGaugeVec( | ||
| prometheus.GaugeOpts{ | ||
| // Namespace: AppName, |
There was a problem hiding this comment.
I can't find any reference as to what's the app name you call this. mqtt, mochicomqtt, etc? can you provide one?
| @@ -68,6 +69,9 @@ func (l *HTTPStats) Init(log *zerolog.Logger) error { | |||
|
|
|||
| mux := http.NewServeMux() | |||
| mux.HandleFunc("/", l.jsonHandler) | |||
| mux.Handle("/metrics", promhttp.Handler()) | |||
|
|
|||
| // mux.Handle("/metrics", promhttp.) | |||
There was a problem hiding this comment.
that was a mistake... 😄
|
Overall this looks good! However, I wonder if it would be possible to implement it as a hook, as not everyone will want to overhead of prometheus in the main code. If we used |
|
I was originally thinking creating a sub-module, but since all its data are coming from the System, so it may make sense just be part of that. The way I registered the metrics, there is really no activities on it unless there is a pull on the handle. And upon pull, it does atomic load of the values. I was thinking of putting as a config into the sysinfo, but that config only contains TLS and is shared with many other listeners. As a result I hardcoded into the sysinfo listener. I'm open to suggestion how you would like to have this implemented:
|
|
I'll resubmit a PR in the future. |
@mochi-co , I had to do
go vendorto add modules in go.mod. So you may want to ignore go.mod and go.sum and regenerate them on your side.