Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#78 storage hook should not execute the relevant code if the client has been reconnected #198

Merged
merged 2 commits into from
Apr 21, 2023
Merged

#78 storage hook should not execute the relevant code if the client has been reconnected #198

merged 2 commits into from
Apr 21, 2023

Conversation

werbenhu
Copy link
Member

storage hook should not execute the relevant code if the client has been reconnected.

@mochi-co mochi-co added the bug Something isn't working label Apr 17, 2023
@coveralls
Copy link

coveralls commented Apr 17, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4728404382

  • 9 of 9 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 98.601%
Totals Coverage Status
Change from base Build 4394630949: 0.002%
Covered Lines: 5146
Relevant Lines: 5219
💛 - Coveralls

@werbenhu
add test cases for coverage decrease
0f1ec01 
add test cases for coverage decrease
mochi-co
mochi-co approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@mochi-co mochi-co left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! This looks good to me. Thank you for adding tests too :)

@mochi-co mochi-co merged commit ed7fd83 into mochi-mqtt:master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mochi-co mochi-co mochi-co approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@werbenhu @coveralls @mochi-co