Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expire session if SessionExpiryInterval is 0 #216

Merged
merged 2 commits into from
May 6, 2023

Conversation

thedevop
Copy link
Collaborator

@thedevop thedevop commented May 6, 2023

If SessionExpiryInterval was not set in CONNECT, SessionExpiryIntervalFlag is also not set. According to spec:
If the Session Expiry Interval is absent the value 0 is used. If it is set to 0, or is absent, the Session ends when the Network Connection is closed.

If SessionExpiryInterval was not set in CONNECT, SessionExpiryIntervalFlag is also not set. According to spec:
  If the Session Expiry Interval is absent the value 0 is used. If it is set to 0, or is absent, the Session ends when the Network Connection is closed.
@coveralls
Copy link

coveralls commented May 6, 2023

Pull Request Test Coverage Report for Build 4900778884

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.602%

Totals Coverage Status
Change from base Build 4900770486: 0.0%
Covered Lines: 5148
Relevant Lines: 5221

💛 - Coveralls

@mochi-co
Copy link
Collaborator

mochi-co commented May 6, 2023

Great catch. I will merge this immediately 👍🏻 Thanks as always, @thedevop !

@mochi-co mochi-co merged commit 9233e6f into mochi-mqtt:master May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants