Add support for possible outputs from #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`erlang:decode_package/3` so they can be handled gracefully.
etrepum
added a commit
that referenced
this pull request
Aug 1, 2013
Add support for all possible outputs of erlang:decode_packet/3
etrepum
added a commit
that referenced
this pull request
Aug 1, 2013
etrepum
added a commit
that referenced
this pull request
Aug 1, 2013
tsloughter
pushed a commit
to heroku/mochiweb
that referenced
this pull request
Sep 18, 2013
tsloughter
pushed a commit
to heroku/mochiweb
that referenced
this pull request
Sep 18, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having problems with mochiweb when a client issues an HTTP command like this:
This will be decoded using
erlang:decode_package/3and will cause an error in the filemochiweb.erlcausing that acceptor to crash with a function clause error. This is happening because the output ofdecode_packge/3is{scheme, HttpString, HttpString}which is not handled in the functionmochiweb:new_request/1.I patched that file to support all possible outputs from
decode_package/3so I'm able to return an error message to the clients. Both NGINX and Apache return 400 by default.I'm not sure requests like this should be forwared to the user of the mochiweb server or just be unsupported. If they are supposed to be unsupported an error (400?) should probably be returned instead.