Fix for mochiweb_acceptor crash under R15B02 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source is still unclear but R15B02 now will return and emsgsize error
if the received packet is larger than the recvbuf. This can be tested with
the following (sorry I don't know how to integrate this sort of test into
mochiweb's tests).
-module(mochi_test).
-export([start/0,
handle_http/1,
test/1]).
start() ->
application:start (inets),
mochiweb_http:start([{port, 5678}, {loop, fun(Req) -> handle_http(Req) end}]).
handle_http(Req) ->
Req:respond({ 200,
[ {"Content-Type", "text/html"} ],
[ "<html><body>Hello</body></html>" ]
}).
test (Len) ->
httpc:request (get, {"http://127.0.0.1:5678/",
[{"X-Random", [$a || _ <- lists:seq(1,Len)]}]}, [], []).
Once compiled you can run this with
erl -pa ebin -boot start_sasl
Then run with
mochi_test:start().
mochi_test:test(10000).
The result is different with R14B04 and R15B02. With R15B02 there was
a crash in the mochiweb_acceptor. This patch deals with that crash.
etrepum
added a commit
that referenced
this pull request
Dec 15, 2012
Fix for mochiweb_acceptor crash under R15B02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source is still unclear but R15B02 now will return and emsgsize error
if the received packet is larger than the recvbuf. This can be tested with
the following (sorry I don't know how to integrate this sort of test into
mochiweb's tests).
Once compiled you can run this with
erl -pa ebin -boot start_sasl
Then run with
mochi_test:start().
mochi_test:test(10000).
The result is different with R14B04 and R15B02. With R15B02 there was
a crash in the mochiweb_acceptor. This patch deals with that crash.