Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to JUnit5 #420

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

migrate to JUnit5 #420

wants to merge 1 commit into from

Conversation

hennr
Copy link
Contributor

@hennr hennr commented Mar 23, 2021

Not sure if you want to, but why not migrate to JUnit 5 I thought :)

@TimvdLippe
Copy link
Contributor

Ideally I would like to do this when we switch over the main Mockito test suite (mockito/mockito#1246) and I don't think we want to move to JUnit 5 just yet. Let's discuss further in the Mockito issue before we merge any PRs related to JUnit 5.

@hennr
Copy link
Contributor Author

hennr commented Mar 23, 2021

All right, no worries. If you need a helping hand on the other test code, let me know.

@bohsen
Copy link

bohsen commented Mar 23, 2021

@hennr Just curious. What are the advantages of using junit5 over junit4 (with respect to an updated junit dependency like junit 4.13.2)?

@TimvdLippe
Copy link
Contributor

@bohsen That would be the same question for me, but let's move that discussion to the Mockito issue rather than this PR, so that we can keep this PR focused on the implementation. Thanks!

@niki-belo-scacap
Copy link

You folks might consider closing this one - it's been a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants