Skip to content

Drop EqMatchers_VersionSpecific (they aren't specific) #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2025
Merged

Drop EqMatchers_VersionSpecific (they aren't specific) #575

merged 1 commit into from
Jul 2, 2025

Conversation

jozic
Copy link
Contributor

@jozic jozic commented Jul 2, 2025

After we dropped Scala 2.11, these matchers are no longer specific and work for Scala versions 2.12+

TimvdLippe
TimvdLippe approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. The PR is marked as draft, are you planning to do more cleanups?

@jozic jozic marked this pull request as ready for review July 2, 2025 09:41
@jozic
Copy link
Contributor Author

jozic commented Jul 2, 2025

@TimvdLippe
no, it's good to merge now, i usually start all PRs as drafts to see first that CI is happy before requesting reviews

And thanks for quick review even before I requested one :)

@TimvdLippe TimvdLippe merged commit 1e49fbf into mockito:release/2.x Jul 2, 2025
5 checks passed
@jozic jozic deleted the drop-version-specific-eq-to branch July 2, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimvdLippe TimvdLippe TimvdLippe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jozic @TimvdLippe