Make tests scala 3 friendlier #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jozic
force-pushed
the
scala-3-friendlier-tests
branch
from
de59e33 to
1aafae0
Compare
jozic
force-pushed
the
scala-3-friendlier-tests
branch
from
1aafae0 to
58cb6d9
Compare
|
@TimvdLippe please check it out, should be an easy one |
TimvdLippe
reviewed
Jul 18, 2025
| @@ -317,14 +316,6 @@ class MockitoSugarTest extends AnyWordSpec with MockitoSugar with Matchers with | |||
| org.takesManyValueClasses(new ValueClass("1"), ValueCaseClassInt(2), ValueCaseClassString("3")) shouldBe "ValueClass(1)-ValueCaseClassInt(2)-ValueCaseClassString(3)" | |||
| } | |||
|
|
|||
| "not mock final methods" in { | |||
| val abstractFile = mock[AbstractFile] | |||
There was a problem hiding this comment.
Can we create our own class which has final methods and mock those instead?
There was a problem hiding this comment.
I can do that but I'm not sure what the test should be, as the current test is basically testing regular method stubbing
val abstractFile = mock[AbstractFile]
when(abstractFile.path) thenReturn "sammy.scala"
abstractFile.path shouldBe "sammy.scala"
}
Do you have an idea what the real test should look like?
There was a problem hiding this comment.
I don't recall to be honest. I am okay with merging as-is and see if we regress in the future, as the commit in question doesn't mention the motivation for the bug unfortunately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are low hanging fruits on the path to Scala 3. Not 100% sure we gonna get there without loses, but I hope so :)
One minor concern is dropped test using
scala.reflect.io.AbstractFile(which doesn't exist in Scala 3) and namednot mock final methodsbut that methodpathis not final, so I'm not sure what exactly that test was doing.Maybe @ultrasecreth can shed some light.