Skip to content

Commit

Permalink
Removed redundant dependency from CI's job
Browse files Browse the repository at this point in the history
Because 'build' job in CI workflow is dependent on 'verify', and 'build' is needed by 'release' job, 'verify' dependency is redundant in 'release' job and it can be removed.
Also checking against commit message containing '[skip ci]' can be removed from 'build' job - it is already checked in 'verify'.
  • Loading branch information
shestee committed Jan 19, 2021
1 parent 60f02d9 commit 164a2c1
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ jobs:
build:
needs: [verify]
runs-on: ${{ matrix.os }}
if: "! contains(toJSON(github.event.commits.*.message), '[skip ci]')"

# Definition of the build matrix
strategy:
Expand All @@ -75,7 +74,7 @@ jobs:

release:
runs-on: ubuntu-latest
needs: [build, verify] # build job must pass before we can release
needs: [build] # build job must pass before we can release

if: github.event_name == 'push'
&& github.ref == 'refs/heads/master'
Expand Down

0 comments on commit 164a2c1

Please sign in to comment.