Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github Action and build improvement #21

Merged
merged 2 commits into from
Dec 4, 2020
Merged

Github Action and build improvement #21

merged 2 commits into from
Dec 4, 2020

Conversation

slawekjaranowski
Copy link
Member

@slawekjaranowski slawekjaranowski commented Nov 29, 2020 •
edited
Loading

  • add branch master to build on push - when we have only tags-ignore - build not run on other events
  • support skip ci on verify job
  • fix build reproducibility - I guess that this will be needed during release
  • add badge icon for GitHub Actions in README
  • change Travis Ci to GitHUb Actions in README

some of change take account comments from last PR #19

@skabashnyuk
Copy link

@slawekjaranowski can you please provide a brief description of what this PR about?

@mockitoguy
Made readme more generic
a0fbe00 
This way we don't have to update it next time we change the CI system ;)
@mockitoguy
Copy link
Member

Looks great, thank you!

mockitoguy
mockitoguy approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@mockitoguy mockitoguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I made a little change to the docs and this is ready to go.

@skabashnyuk skabashnyuk merged commit b756889 into mockito:master Dec 4, 2020
@slawekjaranowski
Copy link
Member Author

@skabashnyuk
ups, I don't have luck ...
Something hang on last build - please re-run

@slawekjaranowski
Copy link
Member Author

@skabashnyuk , @mockitoguy
Can you look at last build .. something hang ups on, I think re-run will be good idea

Fri, 04 Dec 2020 09:44:21 GMT Task :bintrayPublish
Fri, 04 Dec 2020 15:43:11 GMT Error: The operation was canceled.

You can consider to give me more power - I can take care about this project

@slawekjaranowski slawekjaranowski mentioned this pull request Dec 7, 2020
Closed
@mockitoguy
Copy link
Member

You can consider to give me more power - I can take care about this project

@slawekjaranowski, I gave you admin rights to the project. Thanks for taking care of it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockitoguy mockitoguy mockitoguy approved these changes

@skabashnyuk skabashnyuk skabashnyuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slawekjaranowski @skabashnyuk @mockitoguy