Apply new Shipkit Changelog plugin properties #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two new properties has been recently added to Shipkit Changelog plugin: 1. 'newTagRevision' eliminates problem with wrong tagging, when release is tagged with revision reference that the release doesn't come from, but is the latest one on master branch. To get the commit SHA that triggered the workflow 'GITHUB_SHA' env var is used. 2. 'githubToken' is used to both to fetch and post, instead of 'readOnlyToken' and 'writeToken'. As the token grants write access to the repository to keep things safe it should be supplied by the env variable. Using this property simplifies configuration. Deprecated properties should be replaced with the new one.
Codecov Report
@@ Coverage Diff @@
## release/3.x #2163 +/- ##
==============================================
Coverage 84.86% 84.86%
Complexity 2720 2720
==============================================
Files 325 325
Lines 8277 8277
Branches 989 989
==============================================
Hits 7024 7024
Misses 981 981
Partials 272 272 Continue to review full report at Codecov.
|
This was referenced Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new properties has been recently added to Shipkit Changelog plugin that is used by Mockito:
newTagRevisioneliminates problem with wrong tagging, when release is tagged with revision reference that the release does not come from, but is the latest one on master branch. To get the commit SHA that triggered the workflow 'GITHUB_SHA' env var is used.githubTokenis used both to fetch and post via GH API, instead ofreadOnlyTokenandwriteToken. As the token assigned to 'githubToken' should have write access to the repository, it should be supplied by the env variable to keep things safe. Using this property simplifies configuration. Deprecated properties should be replaced with the new one.