Skip to content

fix(core): onload events #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2024
Merged

fix(core): onload events #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b91849a
fix(core): calculate unique key for elements with ref
stephancill Jan 19, 2024
982d1cc
fix(react): debounce onload event
stephancill Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/smooth-feet-grow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@mod-protocol/react": patch
"@mod-protocol/core": patch
---

fix: onload events
10 changes: 9 additions & 1 deletion packages/core/src/renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1099,7 +1099,15 @@ export class Renderer {
el: ModElement | ConditionalFlow<ModElement>,
index: number
): T | null => {
const key = index + "";
let key = index + "";

if ("onload" in el) {
if (typeof el.onload === "string") {
key += `-${el.onload}`;
} else if (typeof el.onload === "object" && "ref" in el.onload) {
key += `-${el.onload.ref}`;
}
}

if ("if" in el) {
const { if: if_, then: then_, else: else_ } = el;
Expand Down
6 changes: 4 additions & 2 deletions packages/react/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,8 @@ const WrappedHorizontalLayoutRenderer = <T extends React.ReactNode>(props: {
element: Extract<ModElementRef<T>, { type: "horizontal-layout" }>;
}) => {
const { component: Component, element } = props;
const { events, type, elements, ...rest } = element;
const { type, elements, ...rest } = element;
const [events] = React.useState(element.events);

React.useEffect(() => {
events.onLoad();
Expand All @@ -189,7 +190,8 @@ const WrappedVerticalLayoutRenderer = <T extends React.ReactNode>(props: {
element: Extract<ModElementRef<T>, { type: "vertical-layout" }>;
}) => {
const { component: Component, element } = props;
const { events, type, elements, ...rest } = element;
const { type, elements, ...rest } = element;
const [events] = React.useState(element.events);

React.useEffect(() => {
events.onLoad();
Expand Down