Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make Mount._deploy implicitly Environment-scoped #2553

Merged
merged 1 commit into from
Nov 22, 2024
+2 −1
Merged

make Mount._deploy implicitly Environment-scoped #2553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modal/mount.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,12 +622,13 @@ async def _deploy(
client: Optional[_Client] = None,
) -> None:
check_object_name(deployment_name, "Mount")
environment_name = _get_environment_name(environment_name, resolver=None)
self._deployment_name = deployment_name
self._namespace = namespace
self._environment_name = environment_name
if client is None:
client = await _Client.from_env()
resolver = Resolver(client=client)
resolver = Resolver(client=client, environment_name=environment_name)
await resolver.load(self)

def _get_metadata(self) -> api_pb2.MountHandleMetadata:
Expand Down
Loading