[Issue] Twigs Lamps are not rendering itself or the player.

[MaranRoseGIT]

Self-explanatory

Holding one of the twigs lamps, it's not rendering me or the player, can confirm I'm "invisible" from other players, this seemed to of happened after the newest fabric loader/api update? Unsure, no error logs; here is my latest.log
latest.log

Minecraft Fabric 1.18.2

[MaranRoseGIT]

The issue has been found, It's apparently LambdaDynamicLights https://www.curseforge.com/minecraft/mc-mods/lambdynamiclights

Unsure why it's causing this though, hope to hear from you soon.

[andantet]

twigs-fabric/src/main/java/net/moddingplayground/twigs/init/TwigsBlocks.java

Lines 46 to 47 in 34447f5

	public static final Block LAMP = register("lamp", new LampBlock(AbstractBlock.Settings.of(Material.METAL).requiresTool().strength(4.5F).sounds(BlockSoundGroup.LANTERN).luminance(createLightLevelFromLitBlockState(18))));
	public static final Block SOUL_LAMP = register("soul_lamp", new LampBlock(FabricBlockSettings.copyOf(TwigsBlocks.LAMP).luminance(createLightLevelFromLitBlockState(17))));

I thought this was fixed ages ago, but apparently not!
createLightLevelFromLitBlockState(int) uses 17/18, where the maximum value for 'stable' gameplay is 15

This is fixed in the 1.19 branch leading version 2.0, which I hope to be released very soon, so I'm hesitant to release a direct fix for this

Also, out of interest, are you using a mod pack or just a jumble of mods that you've put together? Just wondering how easy it would be for you to update to 1.19 in the future :)

[MaranRoseGIT]

It's my mod-pack that I have attempted to carefully craft for my players, I am unsure if it is possible to update to 1.19 smoothly, it would most likely be at the end of 2022, by that point most of the mods I have should be updated to 1.19.

Is there any chance at a small patch for 1.18.2 for the time being? If not, I understand.

[andantet]

I'll release a patch soon :)

[MaranRoseGIT]

Much appreciated!

[MaranRoseGIT]

Oh, I forgot to ask, when will you release this patch, so I can test it out and report back?

[andantet]

I'm not home right now so the best I can say is as soon as possible 😅

[MaranRoseGIT]

Alright, thank you!

[andantet]

Due to some real life complications, I'm going to have to push this back a day or two, apologies!

[MaranRoseGIT]

Due to some real life complications, I'm going to have to push this back a day or two, apologies!

Hey, it's alright! I have the entire week to wait, to test this out before I will be busy myself; but as soon as you release it, I'll report back to you asap!

[andantet]

Doing this right now

[MaranRoseGIT]

Is it currently in the process of getting uploaded to curseforge?

[andantet]

Yep, just under automatic review at the moment

[andantet]

Approved!

[MaranRoseGIT]

It's fixed, thank you so much! Just in time too!