Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freeze dev requirements, update dev tooling #103

Merged
merged 2 commits into from
Sep 4, 2020
Merged

Freeze dev requirements, update dev tooling #103

merged 2 commits into from
Sep 4, 2020

Conversation

amureki
Copy link
Collaborator

@amureki amureki commented Sep 4, 2020 •
edited
Loading

Changed

  • [dev] Freeze dev requirements
  • [dev] Add Django 3.1 to test matrix
  • [dev] pre-commit to use local packages (so versions will match)
  • [dev] consistent use of pydocstyle

Also, code was reformatted due to the latest black release (that was the reason for freezing dependencies, as it broke main branch's CI).

@amureki amureki self-assigned this Sep 4, 2020
@amureki amureki requested a review from a team September 4, 2020 12:38
@amureki amureki added the enhancement New feature or request label Sep 4, 2020
anapaulagomes
anapaulagomes approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@anapaulagomes anapaulagomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, @amureki! 🍾

@amureki
Copy link
Collaborator Author

amureki commented Sep 4, 2020

@anapaulagomes thanks for blazing fast response, Ana ❤️

@amureki amureki merged commit 8564395 into master Sep 4, 2020
@amureki amureki deleted the freeze_dev_requirements branch September 4, 2020 16:38
@amureki amureki mentioned this pull request Sep 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anapaulagomes anapaulagomes anapaulagomes approved these changes

Assignees

@amureki amureki

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amureki @anapaulagomes