Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action corrupts local rust registry #30

Closed
ChristopherRabotin opened this issue Mar 14, 2023 · 5 comments
Closed

Action corrupts local rust registry #30

ChristopherRabotin opened this issue Mar 14, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@ChristopherRabotin
Copy link

I tried to run my typical Github action for Kani. Historically, this has never caused any issues for the installation of crates. However, on my recent pushes, cargo seems to no longer be able to find optional registries: https://github.com/nyx-space/hifitime/actions/runs/4399579815/jobs/7704213779 . I am not sure what has happened.

@ChristopherRabotin ChristopherRabotin added the bug Something isn't working label Mar 14, 2023
@karkhaz karkhaz self-assigned this Mar 14, 2023
karkhaz added a commit to karkhaz/hifitime that referenced this issue Mar 14, 2023
This commit adds `-Z sparse-registry` to the cargo kani invocation,
which is needed to update crates over HTTP.

This commit fixes model-checking/kani-github-action#30
@karkhaz
Copy link
Contributor

karkhaz commented Mar 14, 2023

Hi there,

I'm not a rust expert but this comment suggests that sparse registries are used from Rust 1.68 (released last week 2023-03-09). Continuing to look into this

@adpaco-aws
Copy link
Contributor

Hi @ChristopherRabotin , it doesn't look like Hifitime uses the Kani Github Action.

In any case, the step that installs the stable Rust toolchain is setting CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse (resetting that variable may work as a patch for now). It seems that it's always failing to compile der using sparse registries, right?

@ChristopherRabotin
Copy link
Author

ChristopherRabotin commented Mar 14, 2023 via email

@ChristopherRabotin
Copy link
Author

Using the Github Action does not cause the issue: https://github.com/nyx-space/hifitime/actions/runs/4417201736/jobs/7742569934 . Closing, and sorry for opening it before checking that I was indeed using the action.

@adpaco-aws
Copy link
Contributor

No worries! I'm glad to see the Kani GitHub Action being useful 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants