Skip to content

Conversation

@tedinski
Copy link
Contributor

@tedinski tedinski commented Apr 18, 2022

Description of changes:

Add a "release bundle" CI step for macos as well.

Turns out, things just work! I opened #1067 to remind me about an issue that I initially thought would affect us, but only seems applicable to macos-arm. So, not relevant yet.

Resolved issues:

Resolves #1036

Towards #1045

Call-outs:

  • Eventually we'll want to "refactor" how we do CI. IMO, we should run regressions on what we build with release bundle, then we'd just have these builds, and not the original ones... eventually.

Testing:

  • How is this change tested? New CI. I did test downloading the artifact and running it locally, however.

  • Is this a refactor change? no

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@tedinski tedinski changed the title [draft] Try building release bundle on macos Build a release bundle for macos Apr 19, 2022
@tedinski tedinski marked this pull request as ready for review April 19, 2022 21:06
@tedinski tedinski requested a review from a team as a code owner April 19, 2022 21:06
@celinval
Copy link
Contributor

The reason why most people use debug build in regressions is because it has more checks like debug_assertions. It usually has more logs as well.

@celinval
Copy link
Contributor

BTW, can you please add a comment why we do things differently on MacOS and Linux.

@tedinski tedinski merged commit a6e01f1 into model-checking:main Apr 20, 2022
@tedinski tedinski deleted the mac-artifact branch April 20, 2022 14:32
tedinski added a commit to tedinski/rmc that referenced this pull request Apr 26, 2022
tedinski added a commit that referenced this pull request Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kani-verifier: cargo-kani setup support for macos

3 participants