Fix cbmc-viewer ci issues with Mac11 #1844
Conversation
| set -x | ||
|
|
||
| # brew doesn't recognize specific versions of viewer | ||
| brew install aws/tap/cbmc-viewer |
There was a problem hiding this comment.
Is this always set at this point? Where is this tap added?
There was a problem hiding this comment.
brew install repo mitigates the need to add a tap but I could make that more explicit if it's safer.
|
|
||
| set -x | ||
|
|
||
| # brew doesn't recognize specific versions of viewer |
There was a problem hiding this comment.
Are we likely to care? Should we ask the tap owners to keep pinned versions in the tap?
There was a problem hiding this comment.
I can't imagine this becoming a problem since viewer isn't updated that often and also brew install installs the latest version of viewer anyway. This patch is also just temporary I imagine, till the issue in github-actions gets fixed or till we find a way to add a path to pip install. This was just the quickest solution, to get everyone's PR's unblocked by CI.
There was a problem hiding this comment.
This is the issue that's causing ci to break, I imagine - actions/runner-images#6507.
There was a problem hiding this comment.
Can we push the fix to unblock us and we can figure out a better long term plan later? If actions/runner-images#6507 gets fixed, we could probably just revert these changes.
| # Install cbmc-viewer | ||
|
|
||
| # Source kani-dependencies to get CBMC_VIEWER_VERSION | ||
| source kani-dependencies |
There was a problem hiding this comment.
If we're not installing a specific version, then we shouldn't need to source kani-dependencies.
Description of changes:
CI is broken because of an issue in actions - actions/runner-images#6507. This is a patch to fix viewer installation in mac os till the issue is fixed.
Call-outs:
We aren't specifying version number with Mac because that breaks the CI. Brew is unable to recognize specific version numbers of CBMC-Viewer and can only install the latest version.
Testing:
How is this change tested? Regression and CI in fork
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.