Don't rely on JSON symtabs for --gen-c, --function #2221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-delmas-3000
added
the
[C] Internal
remi-delmas-3000
force-pushed
the
dont-rely-on-json-symtab
branch
from
a959353 to
3e4dd56
Compare
4 tasks
zhassan-aws
approved these changes
Feb 20, 2023
Contributor
zhassan-aws
left a comment
zhassan-aws
left a comment
There was a problem hiding this comment.
Thanks! One minor comment. Otherwise looks good.
When `--write-goto-binary` is used, JSON symtab files are not produced, so we should not rely on them. For `--gen-c` we now store the `name` to `prettyName` mapping in its own JSON `ArtifactType::PrettyNameMap`. For `--function`, we modify `CargoOutputs` so that it tracks GOTO symtabs instead of JSON symtabs.
remi-delmas-3000
force-pushed
the
dont-rely-on-json-symtab
branch
from
3e4dd56 to
c3b7034
Compare
celinval
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
When
--write-goto-binaryis used, JSON symtab files are not produced, so we should not rely on them.For
--gen-cwe now store thenametoprettyNamemapping in its own JSONArtifactType::PrettyNameMap.For
--function, we modifyCargoOutputsso that it tracks GOTO symtabs instead of JSON symtabs.Testing:
CI regression run.
No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.