Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade toolchain to nightly-2023-03-09 #2293

Closed
wants to merge 2 commits into from

Conversation

qinheping
Copy link
Contributor

@qinheping qinheping commented Mar 10, 2023

Description of changes:

Upgrade our toolchain to nightly-2023-03-09. The changes here are related to the following changes:

Resolved issues:

Resolves #2283

Related RFC:

Optional #ISSUE-NUMBER.

Call-outs:

Testing:

  • How is this change tested?

  • Is this a refactor change?

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@qinheping qinheping requested a review from a team as a code owner March 10, 2023 08:28
@qinheping qinheping marked this pull request as draft March 10, 2023 08:33
Copy link
Contributor

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this @qinheping!

@@ -6,10 +6,10 @@

use crate::kani_middle::reachability::{collect_reachable_items, filter_crate_items};
use crate::kani_middle::stubbing;
use crate::kani_middle::ty::query::query_provided::collect_and_partition_mono_items;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks a bit odd. Isn't this importing collect_and_partition_mono_items from rustc_middle? If so, why is it referring to crate::kani_middle?

@tautschnig
Copy link
Member

I have rebased the branch to include the CBMC 5.79.0 update to make sure this dependency is sorted out (but obviously we are currently failing well before reaching CBMC). I will look into those failures.

@tautschnig tautschnig force-pushed the issue-2283-toolchain branch 3 times, most recently from 9db9cb5 to 30eb983 Compare March 17, 2023 19:48
tautschnig and others added 2 commits April 17, 2023 17:35
Upstream PRs that require local changes:

- Switch to EarlyBinder for type_of query rust-lang/rust#107753
- Factor query arena allocation out from query caches rust-lang/rust#107833

Co-authored-by: Qinheping Hu <qinhh@amazon.com>
- Introduce -Zterminal-urls to use OSC8 for error codes rust-lang/rust#107838
- Unify validity checks into a single query rust-lang/rust#108364
- Rename interner funcs rust-lang/rust#108250
- Optimize mk_region rust-lang/rust#108020
- Clarify iterator interners rust-lang/rust#108112
celinval added a commit to celinval/kani-dev that referenced this pull request Apr 25, 2023
This is related to the performance degradation we are seeing in the
toolchain upgrade: model-checking#2293
celinval added a commit that referenced this pull request Apr 28, 2023
Use the overflow result operations instead of doing the math twice.

This is related to the performance degradation we are seeing in the toolchain upgrade: #2293

Co-authored-by: Michael Tautschnig <tautschn@amazon.com>
@qinheping qinheping closed this May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update rust toolchain version for Kani 0.24
3 participants