-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade toolchain to nightly-2023-03-09 #2293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this @qinheping!
@@ -6,10 +6,10 @@ | |||
|
|||
use crate::kani_middle::reachability::{collect_reachable_items, filter_crate_items}; | |||
use crate::kani_middle::stubbing; | |||
use crate::kani_middle::ty::query::query_provided::collect_and_partition_mono_items; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks a bit odd. Isn't this importing collect_and_partition_mono_items
from rustc_middle
? If so, why is it referring to crate::kani_middle
?
9e4d1cb
to
0cfe538
Compare
I have rebased the branch to include the CBMC 5.79.0 update to make sure this dependency is sorted out (but obviously we are currently failing well before reaching CBMC). I will look into those failures. |
9db9cb5
to
30eb983
Compare
Upstream PRs that require local changes: - Switch to EarlyBinder for type_of query rust-lang/rust#107753 - Factor query arena allocation out from query caches rust-lang/rust#107833 Co-authored-by: Qinheping Hu <qinhh@amazon.com>
- Introduce -Zterminal-urls to use OSC8 for error codes rust-lang/rust#107838 - Unify validity checks into a single query rust-lang/rust#108364 - Rename interner funcs rust-lang/rust#108250 - Optimize mk_region rust-lang/rust#108020 - Clarify iterator interners rust-lang/rust#108112
30eb983
to
53e07cc
Compare
This is related to the performance degradation we are seeing in the toolchain upgrade: model-checking#2293
Use the overflow result operations instead of doing the math twice. This is related to the performance degradation we are seeing in the toolchain upgrade: #2293 Co-authored-by: Michael Tautschnig <tautschn@amazon.com>
Description of changes:
Upgrade our toolchain to
nightly-2023-03-09
. The changes here are related to the following changes:-Zterminal-urls
to use OSC8 for error codes rust-lang/rust#107838target
instead ofmachine
for mir interpreter integer handling. rust-lang/rust#108047EarlyBinder
fortype_of
query rust-lang/rust#107753mk_region
rust-lang/rust#108020Resolved issues:
Resolves #2283
Related RFC:
Optional #ISSUE-NUMBER.
Call-outs:
Testing:
How is this change tested?
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.