-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update toolchain to nightly 2023-08-04 #2661
Update toolchain to nightly 2023-08-04 #2661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good. I was just wondering if there's any specific reason why you updated our dependencies. If there's no reason, can you please revert those changes and push a separate PR?
BTW, thanks for fixing the documentation warnings. We should probably enforce no warnings in our CI but not here.
Thanks again!
there's a clang-format-14 reports formatting error on the vec.c stub, but I could not reproduce it locally so I could not fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @remi-delmas-3000 !
here's a clang-format-14 reports formatting error on the vec.c stub, but I could not reproduce it locally so I could not fix.
Looks like it's been there for a while (seen it in other PRs) and our workflow is set to continue on errors from clang-format.
Description of changes:
bump toolchain to nightly-2023-08-04
Call-outs:
tests/expected/slice_c_str/c_str.c
because of ongoing refactor of c_str_literals Tracking Issue forc"…"
string literals rust-lang/rust#105723Testing:
CI tests are passing. Built and tested on Apple M1.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.