Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for floating point remainder issue #2679

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

reisnera
Copy link
Contributor

See issue #2669

Description of changes:

Adds a fixme test for the fact that floating point remainder is currently nondeterministic.

Resolved issues:

n/a

Related RFC:

n/a

Call-outs:

n/a

Testing:

  • How is this change tested?

  • Is this a refactor change?

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@reisnera reisnera requested a review from a team as a code owner August 12, 2023 21:06
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@zhassan-aws zhassan-aws enabled auto-merge (squash) August 14, 2023 21:43
@zhassan-aws zhassan-aws merged commit f9e2cef into model-checking:main Aug 14, 2023
12 checks passed
@reisnera reisnera deleted the float-remainder branch August 14, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants