Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker build step in release workflow #2854

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

adpaco-aws
Copy link
Contributor

Output the tagged version in the versioning step of the release workflow to avoid a failure in the posterior docker build step (see #2851 for more details).

This has been tested in my fork, where:

  1. Pushing the kani-0.40.0 without any changes generated the same failure in this run
  2. Committing the change in this PR and pushing the kani-0.40.0 again resulted in a successful build in this run
  3. The tagged image can be downloaded from my fork, as seen here.

Resolves #2851

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco-aws adpaco-aws requested a review from a team as a code owner November 2, 2023 21:50
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@adpaco-aws adpaco-aws merged commit 341836c into model-checking:main Nov 2, 2023
20 checks passed
jaisnan added a commit that referenced this pull request Nov 17, 2023
Upgrade version number to 0.41.0

The CHANGELOG changes are:

```
# What's Changed
* Fix setup for `aarch64-unknown-linux-gnu` platform by @adpaco-aws in #2864
* Do not override `std` library during playback by @celinval in #2852
* Fix docker build step in release workflow by @adpaco-aws in #2854
* Fix path-dependent failures in `assess-artifacts` test by @adpaco-aws in #2849
* Automatic toolchain upgrade to nightly-2023-11-11 by @github-actions in #2870

**Full Changelog**: kani-0.40.0...kani-0.41.0

### Breaking Changes

* Set minimum python to 3.7 in docker container and release action by @remi-delmas-3000 in #2879
* Delete `any_slice` which has been deprecated since Kani 0.38.0. by @zhassan-aws in #2860
```

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package Docker CI job failed during release
2 participants