-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate hooks and place modules to use mostly StableMIR APIs #2910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We still need to migrate `codegen_place` to get this working.
We will need the same logic for other components as we slowly migrate to StableMIR. Move that to `ty_stable.rs` for now.
adpaco-aws
reviewed
Dec 8, 2023
Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
adpaco-aws
approved these changes
Dec 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @celinval !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main changes needed to make this migration besides a few method call tweaks were:
FunctionCtx
to cache information about the StableMIR version of instance and its body.Place
when retrieved from StableMIR body already comes monomorphized, I modified the existingcodegen_place
to preemptively monomorphize Place before converting it to a Stable version and invokingcodegen_place_stable
.Call-outs
Leaving this as a draft for now since this still depends on the following PRs to be merged into the Rust compiler:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.