-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable powf*, exp*, log* intrinsics #2996
Conversation
CBMC provides approximating implementations of these. Resolves: model-checking#2763, model-checking#2966
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to add tests for exp, and sqrt as well similar to the powf test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to have at least one test for each intrinsic that's being enabled here. I'd recommend separate PRs for each group of intrinsics.
Yes, more tests need to be added. But doing one PR per group is excessive overhead that I'm not willing to take on. |
Nudge. I believe there is a customer blocked on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM module log tests.
## What's Changed * `modifies` Clauses for Function Contracts by @JustusAdam in #2800 * Fix ICEs due to mismatched arguments by @celinval in #2994. Resolves the following issues: * #2260 * #2312 * Enable powf*, exp*, log* intrinsics by @tautschnig in #2996 * Upgrade Rust toolchain to nightly-2024-01-24 by @celinval @feliperodri @qinheping **Full Changelog**: kani-0.45.0...kani-0.46.0 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. --------- Signed-off-by: Felipe R. Monteiro <felisous@amazon.com> Co-authored-by: Celina G. Val <celinval@amazon.com>
CBMC provides approximating implementations of these.
Resolves: #2966
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.