Dashboard: Avoid "field is never read" warnings #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinval
reviewed
Nov 18, 2021
src/tools/dashboard/src/books.rs
Outdated
Contributor
There was a problem hiding this comment.
I don't think we need this hack anymore. We should be able to verify binary crates now.
Contributor
Author
There was a problem hiding this comment.
Thanks!! I have left a review there and hope we can merge it soon. Should we reuse this PR for the warning changes or close it and open a new one with them?
Contributor
There was a problem hiding this comment.
We can reuse it. Maybe just make sure you edit the title!
Contributor
Author
There was a problem hiding this comment.
Updated PR to contain only the warnings changes.
adpaco-aws
changed the title
celinval
approved these changes
Nov 22, 2021
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Declare each Litani struct field as public to remove "field is never read" warnings.
Call-outs:
Testing:
How is this change tested? Running dashboard.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.