Refactor with Book struct and set default edition for each book
#670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpaco-aws
force-pushed
the
dash-default
branch
from
8ea7408 to
5962544
Compare
Contributor
Author
|
Thanks @zhassan-aws ! Rebased and added two minor comments, merging now. |
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
…del-checking#670) * Refactor with `Book` struct and set default edition for each book * Comments
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Refactor with `Book` struct and set default edition for each book * Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Turns out default editions are different for each book: https://rust-lang.zulipchat.com/#narrow/stream/237824-t-lang.2Fdoc
Refactored the dashboard code to include an extensible
Bookstructure which contains all information related to a particular book. This allows us to set the correct default edition for the examples in each book.Resolved issues:
Resolves #666
Testing:
How is this change tested? Running dashboard locally.
Is this a refactor change? No, but includes some refactoring.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.