Support for fast math intrinsics #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpaco-aws
commented
Feb 7, 2022
| @@ -129,6 +129,13 @@ impl Stmt { | |||
| _ => None, | |||
| } | |||
| } | |||
|
|
|||
| pub fn get_stmts(&self) -> Option<&Vec<Stmt>> { | |||
There was a problem hiding this comment.
This is part of an earlier version where the intrinsics where encoded in a block statement, so I needed to retrieve statements within in order to prepend the finite checks. This version does not use it, but I figured it could be useful for something else. We can remove it otherwise.
There was a problem hiding this comment.
If you do keep it, can you please add a comment?
celinval
reviewed
Feb 7, 2022
| (false, false) => kani::assume(x > f64::MIN - y), | ||
| _ => (), | ||
| } | ||
| let _z = unsafe { std::intrinsics::fadd_fast(x, y) }; |
There was a problem hiding this comment.
Can you please assert that the result is equal to regular add? The same for the other tests.
There was a problem hiding this comment.
Changed it so we assert it in the case of addition and substraction, as other operations show serious performance issues. Created #809 to revisit this.
| @@ -129,6 +129,13 @@ impl Stmt { | |||
| _ => None, | |||
| } | |||
| } | |||
|
|
|||
| pub fn get_stmts(&self) -> Option<&Vec<Stmt>> { | |||
There was a problem hiding this comment.
If you do keep it, can you please add a comment?
|
Some changes I made:
|
celinval
approved these changes
Feb 8, 2022
Closed
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 22, 2022
* Support for fast math intrinsics * Add (failing) positive test for `fadd_fast` * Undo change in `typecheck_binop_args` * Encode fast math intrinsics as regular binops * Add all tests for fast math intrinsics * Add tests for 32-bit values and compare results * Drop support for `frem_fast` * Add comment to `get_stmts`
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 25, 2022
* Support for fast math intrinsics * Add (failing) positive test for `fadd_fast` * Undo change in `typecheck_binop_args` * Encode fast math intrinsics as regular binops * Add all tests for fast math intrinsics * Add tests for 32-bit values and compare results * Drop support for `frem_fast` * Add comment to `get_stmts`
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
* Support for fast math intrinsics * Add (failing) positive test for `fadd_fast` * Undo change in `typecheck_binop_args` * Encode fast math intrinsics as regular binops * Add all tests for fast math intrinsics * Add tests for 32-bit values and compare results * Drop support for `frem_fast` * Add comment to `get_stmts`
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Support for fast math intrinsics * Add (failing) positive test for `fadd_fast` * Undo change in `typecheck_binop_args` * Encode fast math intrinsics as regular binops * Add all tests for fast math intrinsics * Add tests for 32-bit values and compare results * Drop support for `frem_fast` * Add comment to `get_stmts`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Models fast math intrinsics as regular floating point operations. Includes function to check inputs are finite arguments. Adds 16 new test cases (8 positive, 8 negative) for testing fast math intrinsics.
Resolved issues:
Resolves #788
Call-outs:
Testing:
How is this change tested? Existing regression + 16 new tests.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.