Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Updates for "Limitations" #998

Merged
merged 6 commits into from
Apr 5, 2022
Merged

Documentation: Updates for "Limitations" #998

merged 6 commits into from
Apr 5, 2022

Conversation

adpaco-aws
Copy link
Contributor

@adpaco-aws adpaco-aws commented Mar 30, 2022 •
edited
Loading

Description of changes:

Updates for the "Limitations" section:

  • Revises all items in the intrinsics table (a final review is still expect when Intrinsics Audit #727 is complete).
  • Includes the debug_assert* macros in the overrides table.
  • Updates the note on the standard library to mention overrides.
  • Adds content to the "Limitations" chapter article.
  • Other minor fixes.

Resolved issues:

Part of #700

Call-outs:

Testing:

  • How is this change tested? N/A

  • Is this a refactor change? No.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco-aws adpaco-aws changed the title Doc review limit a Documentation: Updates for "Limitations" Mar 30, 2022
@adpaco-aws adpaco-aws marked this pull request as ready for review March 31, 2022 15:15
@adpaco-aws adpaco-aws requested a review from a team as a code owner March 31, 2022 15:15
@adpaco-aws
Copy link
Contributor Author

Marked this PR as ready to review after adding content to limitations.md. Let me know if you have concerns about it.

@adpaco-aws adpaco-aws merged commit 0f06f8c into model-checking:main Apr 5, 2022
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 22, 2022
@adpaco-aws @tedinski
Documentation: Updates for "Limitations" (model-checking#998)
4e131b2 
* Documentation: Updates for "Rust feature support"

* Documentation: Updates for "Overrides"

* Add contents to main chapter

* Restore empty "Guarantees" section
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 25, 2022
@adpaco-aws @tedinski
Documentation: Updates for "Limitations" (model-checking#998)
0981b11 
* Documentation: Updates for "Rust feature support"

* Documentation: Updates for "Overrides"

* Add contents to main chapter

* Restore empty "Guarantees" section
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 26, 2022
@adpaco-aws @tedinski
Documentation: Updates for "Limitations" (model-checking#998)
518da07 
* Documentation: Updates for "Rust feature support"

* Documentation: Updates for "Overrides"

* Add contents to main chapter

* Restore empty "Guarantees" section
tedinski pushed a commit that referenced this pull request Apr 27, 2022
@adpaco-aws @tedinski
Documentation: Updates for "Limitations" (#998)
7dfb5e4 
* Documentation: Updates for "Rust feature support"

* Documentation: Updates for "Overrides"

* Add contents to main chapter

* Restore empty "Guarantees" section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhassan-aws zhassan-aws zhassan-aws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adpaco-aws @zhassan-aws