Add harnesses for all public functions of Layout
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exercise all public member functions of `Layout` and assert properties over the result. Some of those should, perhaps, become `ensures` clauses.
celinval
reviewed
Jul 30, 2024
feliperodri
reviewed
Jul 30, 2024
There was a problem hiding this comment.
Some comments from #42 also apply here. So I think maybe we should merge that previous PR first and implement some of the cleanups requested there in this one (e.g., using kani::Arbitrary and moving assertions to ensures clauses).
Co-authored-by: Celina G. Val <celinval@amazon.com>
|
is this blocked on something? |
celinval
approved these changes
Oct 2, 2024
carolynzech
approved these changes
Oct 2, 2024
szlee118
pushed a commit
to stogaru/verify-rust-std
that referenced
this pull request
Oct 17, 2024
Exercise all public member functions of `Layout` and assert properties over the result. Some of those should, perhaps, become `ensures` clauses. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. --------- Co-authored-by: Celina G. Val <celinval@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exercise all public member functions of
Layoutand assert properties over the result. Some of those should, perhaps, becomeensuresclauses.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.