fix: properly handle object type parameters in tools #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Add special handling for object type parameters - Parse JSON input for object parameters - Maintain raw input if JSON parsing fails - Fixes #110 Co-Authored-By: ashwin@anthropic.com <ashwin@anthropic.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
Add "(aside)" to your comment to have me ignore it. |
ashwin-ant
requested changes
Dec 13, 2024
client/src/components/ToolsTab.tsx
Outdated
| @@ -159,13 +159,15 @@ const ToolsTab = ({ | |||
| {key} | |||
| </Label> | |||
| { | |||
| /* @ts-expect-error value type is currently unknown */ | |||
| // @ts-expect-error Tool schema types are not fully typed | |||
There was a problem hiding this comment.
nit: no need to modify unrelated code.
client/src/components/ToolsTab.tsx
Outdated
Comment on lines
208
to
211
| type={ | ||
| // @ts-expect-error Tool schema types are not fully typed | ||
| value.type === "number" ? "number" : "text" | ||
| } |
There was a problem hiding this comment.
same here as above, let's not change unrelated code in this PR
- Reverted @ts-expect-error messages back to original text - Removed unnecessary line breaks in placeholder and type properties - Kept object parameter handling functionality intact Co-Authored-By: ashwin@anthropic.com <ashwin@anthropic.com>
ashwin-ant
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where object parameters are incorrectly stringified in tools.
Link to Devin run: https://app.devin.ai/sessions/d4d101f3e1204c3cb247953a415c0d12