feat: Add ResourceLink #341
Closed
+124
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzolov
requested changes
Jun 26, 2025
| @@ -1601,6 +1605,18 @@ public Double priority() { | |||
| } | |||
| } | |||
|
|
|||
| @JsonInclude(JsonInclude.Include.NON_ABSENT) | |||
| @JsonIgnoreProperties(ignoreUnknown = true) | |||
| public record ResourceLink( // @formatter:off | |||
There was a problem hiding this comment.
At the moment, the ResourceLink content is equivalent to the existing Resource type.
Unfortunately, Java doesn't allow record inheritance. Perhaps we should consider a common interface (not sure how to call it? Perhaps ResourceType ) that both Resource and ResourceLink would implement.
Also it will be useful to have Builder for the ResourceLink similar to the Resource's builder
There was a problem hiding this comment.
That makes sense, I'll push an update
tzolov
pushed a commit
that referenced
this pull request
Jun 27, 2025
- Add ResourceContent interface with common resource metadata methods - Implement ResourceContent in existing Resource class - Add new ResourceLink record class implementing Content and ResourceContent - Update Content interface to support ResourceLink with "resource_link" type (breaking!) - Add tests for ResourceLink serialization/deserialization - Update test expectations to include new resource_link type Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
|
Thank you @bzsurbhi |
|
rebased, squashed, minor adjustments and merged at 2f55dd0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
ResourceLinkas defined in the specMotivation and Context
Adds a missing
ResourceLinktype from the most recent specification versionHow Has This Been Tested?
Added unit tests
Breaking Changes
None
Types of changes
Checklist
Additional context