feat: Add task related things to schema #671
Open
+823
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
changed the title
Contributor
Author
|
I will try to implement this internal first, feel free to continue |
Contributor
Author
|
I would like to add modelcontextprotocol/modelcontextprotocol#1831 to this too |
Contributor
|
Let's wait until the |
Contributor
Author
|
I'm ok to just drop it if time is not OK, and at the same time, I'm implementing it first internal too. |
Contributor
|
Let's park this for now, then. |
Contributor
Author
|
@Kehrlann Just dropped. |
He-Pin
force-pushed
the
taskHink
branch
8 times, most recently
from
584e4a5 to
8544229
Compare
He-Pin
commented
Nov 19, 2025
| @JsonProperty("content") List<Content> content, | ||
| @JsonProperty("isError") Boolean isError, | ||
| @JsonProperty("structuredContent") Object structuredContent, | ||
| @JsonProperty("task") Task task, |
Contributor
Author
There was a problem hiding this comment.
No | type in Java, so add the task here instead of GetTaskRequest | CallToolResult, an Either type will change much code, and Object loses type safety.
He-Pin
force-pushed
the
taskHink
branch
3 times, most recently
from
d8be68c to
354d2e2
Compare
Signed-off-by: He-Pin <hepin1989@gmail.com>
Signed-off-by: He-Pin <hepin1989@gmail.com>
Signed-off-by: He-Pin <hepin1989@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Add modelcontextprotocol/modelcontextprotocol#1732
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context