[Server] Rework registry to combine provider and registry interface, move capabilities out and enable Registry injection in Builder #150
+567
−736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-hertel
force-pushed
the
unified-registry
branch
from
adb9c93 to
39edab4
Compare
chr-hertel
force-pushed
the
unified-registry
branch
from
39edab4 to
075dda0
Compare
…bilities out and enable Registry injection in Builder
chr-hertel
force-pushed
the
unified-registry
branch
from
075dda0 to
819b311
Compare
CodeWithKyrian
approved these changes
Nov 14, 2025
Member
Author
|
@soyuka & @camilleislasse we would merge that instead of #75 and #146 - does that work for the use-cases you have in mind? |
soyuka
approved these changes
Nov 17, 2025
Contributor
soyuka
left a comment
soyuka
left a comment
There was a problem hiding this comment.
Nice I like that we take the capabilities out of the registry.
| public function getTool(string $name): ToolReference | ||
| { | ||
| return $this->tools[$name] ?? throw new ToolNotFoundException($name); | ||
| } |
Contributor
There was a problem hiding this comment.
it'd be nice for reviewing to keep the previous order of methods :D.
Member
Author
There was a problem hiding this comment.
yea fair, i think we're currently a bit rough with PR scopes 😬
| $cursor, | ||
| $limit | ||
| ); | ||
| throw new ResourceNotFoundException($uri); |
Contributor
There was a problem hiding this comment.
weird to log and to throw ?
Comment on lines
+264
to
+269
| if ($includeTemplates) { | ||
| foreach ($this->resourceTemplates as $template) { | ||
| if ($template->matches($uri)) { | ||
| return $template; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if ($includeTemplates) { | |
| foreach ($this->resourceTemplates as $template) { | |
| if ($template->matches($uri)) { | |
| return $template; | |
| } | |
| } | |
| if (!$includeTemplates) { | |
| throw new ResourceNotFoundException($uri); | |
| } | |
| foreach ($this->resourceTemplates as $template) { | |
| if ($template->matches($uri)) { | |
| return $template; | |
| } | |
| } |
5 tasks
camilleislasse
added a commit
to camilleislasse/ai
that referenced
this pull request
Nov 24, 2025
Now that modelcontextprotocol/php-sdk#150 is merged, the Registry can be injected directly into the Builder. This allows replacing the ProfilingLoader with a cleaner TraceableRegistry decorator pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #146
Outer interface does not change => no docs changes required
Fixes #74