Support SSE event "error" #1514
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Streamable HTTP transport for clients currently only attempts to parse SSEs with the "message" event. This PR expands this to also parse SSEs with the "error" event.
Motivation and Context
Some servers use the "error" event in the case of sending a JSON-RPC error response (
JSONRPCError). When this occurs, the SSE is dropped since by the Python MCP SDK and the request never completes or (if configured) times out as no other response is sent. This allows for proper error handling for these servers.How Has This Been Tested?
Locally.
Breaking Changes
None.
Types of changes
Checklist
Additional context
None