fix(sse): preserve base path when resolving message endpoint from SSE #422
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: preserve base path when joining /messages from SSE endpoint Previous behavour, a MCP server at: https://my-mcp-server.com/mcp/weather-alerts/sse would fail to connect to messages as the endpoint would be called as: https://my-mcp-server.com/messages It should be: https://my-mcp-server.com/mcp/weather-alerts/messages
Update sse.py to preserve url base
line length fix
|
Hi, @sterankin! We are working on this problem in this PR Fell free to join us. |
|
Closing as duplicate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using the
sse_client()transport, the server sends theendpointas/messages. This is resolved usingurljoin(url, sse.data), but this strips the full base path (e.g.,/mcp/weather-alerts) and results in incorrect POSTs to the root/messages.Solution
This patch updates the
endpointresolution to correctly deriveuri_basefrom the provided SSE URL by removing/sse, and then joining the relative path properly:This ensures that if the client connects to:
https://example-mcp-server.com/mcp/weather-alerts/sse
The messages are correctly posted to:
https://example-mcp-server..com/mcp/weather-alerts/messages
instead of:
https://example-mcp-server..com/messages
Notes
This is backward-compatible and only affects the computed POST endpoint.
Patch tested successfully against MCP servers behind API gateways.