fix: module not found #26
Open
+50
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@robinroy03 Thank you for your contribution! I see that currently this PR has changes that are related to the proposed "module not found" fix, as well as general formatting changes across the python client file. To make it easier for reviewers to review and accept your changes, and also for the history, could you please split this PR into 2: one with a fix, and another one with formatting changes? |
dsp-ant
requested changes
Sep 28, 2025
a-akimov
reviewed
Oct 10, 2025
| path = Path(server_script_path).resolve() | ||
| server_params = StdioServerParameters( | ||
| command="uv", | ||
| args=["--directory", path.parent, "run", path.name], |
There was a problem hiding this comment.
@robinroy03 currently this example fails because path.parent should be a string. Suggest changing to:
args=["--directory", str(path.parent), "run", path.name],
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Solved #25. Earlier when the user did a command like
uv run client.py "C:\Users\Robin Roy\Desktop\quickstart-resources\weather-server-python\weather.py"it'll throwModuleNotFoundErrorbecause the spawned process was unable to use the.venvlibs. I modifieduvto use the libs.How Has This Been Tested?
I tested it locally for the problems #23 and #24.
Breaking Changes
None.
Types of changes
Checklist