Skip to content

fix: don't wrap errors in streamable http auth client#353

Merged
alexhancock merged 1 commit intomodelcontextprotocol:mainfrom
jamadeo:jamadeo/fix-streamable-http-auth-client
Aug 5, 2025
Merged

fix: don't wrap errors in streamable http auth client#353
alexhancock merged 1 commit intomodelcontextprotocol:mainfrom
jamadeo:jamadeo/fix-streamable-http-auth-client

Conversation

@jamadeo
Copy link
Contributor

@jamadeo jamadeo commented Aug 5, 2025

Motivation and Context

When using the auth client, the errors are wrapped, and matches like this don't work as expected:

Err(StreamableHttpError::SeverDoesNotSupportSse) => {
tracing::debug!("server doesn't support sse, skip common stream");
}

How Has This Been Tested?

Use an auth client to connect to a server that does not support events from a GET connection. When the server responds 405, this match fails and terminates the connection instead of just dropping the listener.

Breaking Changes

No breaking changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@github-actions github-actions bot added T-core Core library changes T-transport Transport layer changes labels Aug 5, 2025
@alexhancock alexhancock merged commit 156a92c into modelcontextprotocol:main Aug 5, 2025
11 checks passed
@github-actions github-actions bot mentioned this pull request Aug 4, 2025
takumi-earth pushed a commit to earthlings-dev/rmcp that referenced this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-core Core library changes T-transport Transport layer changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants