Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dymola 2019 model check fails on class methods #28

Closed
hyumo opened this issue Jul 19, 2018 · 18 comments
Closed

Dymola 2019 model check fails on class methods #28

hyumo opened this issue Jul 19, 2018 · 18 comments

Comments

@hyumo
Copy link

hyumo commented Jul 19, 2018

It is found that in Dymola 2019, modelcheck would fail on ExternData reader class methods, e.g. XMLFile.getReal, JSONFile.getReal etc. It seems that Dymola 2019 has changed their model check routine. It is complaining about not able to find the constructed object when doing a individual model check on the methods.

Check of ExternData.JSONFile.getReal:

Undeclared variable: ExternData.JSONFile.json
in the definition equation
json = ExternData.JSONFile.json

Failed in variable declarations of:
function ExternData.JSONFile.getReal 
input String varName "Key";
output Real y "Real value";
output Boolean exist "= true, if varName exits; = false, if it does not exist and y is set to 0.0";
input ExternData.Types.ExternJSONFile json := ExternData.JSONFile.json;
end ExternData.JSONFile.getReal;

Errors detected in functions.

Check aborted.

ERRORS have been issued.
  • ExternData version: 2.3.4
  • Dymola version: 2019
  • OS: Windows 10 Pro
@tbeu
Copy link
Contributor

tbeu commented Aug 4, 2018

Did it work in older Dymola versions? If yes, can you contact the 3Ds support to ask if the change is by purpose or rather a side-effect? Thanks. I believe it is related to my question in #9 (comment) where I wondered if it is legal Modelica.

@hyumo
Copy link
Author

hyumo commented Aug 4, 2018

Yes, it does work before Dymola 2019. I'll try to contact DS and let you know.

@tbeu
Copy link
Contributor

tbeu commented Aug 5, 2018

Thanks. If it really is an intended error message it would be the show-stopper for ExternData functions. See also mo:#979 (comment).

@hyumo
Copy link
Author

hyumo commented Aug 6, 2018

I've contacted our DS rep on this issue, let's wait and see what was going on.

I'm afraid that, if this is intended, ExternData has to be refactored a bit to pass the constructed object to those reader functions as inputs. It might also be good to encapsulate the c wrapper functions into the class as well. It will also fix the OpenModelica issue I believe.

Let me spend some time on it tonight and see if I can fix it.

@hyumo
Copy link
Author

hyumo commented Aug 6, 2018

BTW, the library still works/simulates as it is before, phew~ It is just those reader functions won't pass the model check and it breaks the unit testing procedure we have internally.

@tbeu
Copy link
Contributor

tbeu commented Aug 6, 2018

Yes, it does work before Dymola 2019.

Are you sure it is a regression? I can reproduce also in Dymola 2018 and 2018 FD01.

@hyumo
Copy link
Author

hyumo commented Aug 6, 2018

I just checked on Dymola 2018FD01. Yes, I can reproduce this error. Sorry about this. I need to check which version of Dymola the our CI server is using.

@tbeu
Copy link
Contributor

tbeu commented Aug 6, 2018

It also occurs on older versions, e.g., Dymola 2016.

@hyumo
Copy link
Author

hyumo commented Aug 6, 2018

I think I figured what was going on.

I usually just do a model check on the whole package, Dymola usually skips those encapsulated functions. That's why they never showed up as errors. Using the testing library provided by Dymola, for some reason, gives different results between 2018FD01 and 2019.

Dymola 2018FD01 Testing lib behaves identical as doing a modelcheck on the whole package, which means all the encapsulated functions are excluded.
Dymola 2019 Testing lib behaves differently, it check all functions, no function is skipped.

Conclusion: this is a testing library inconsistent issue.

Thanks for the help, please close this issue if needed. I still think the syntax should be changed though, just to make it legal Modelica.

@tbeu
Copy link
Contributor

tbeu commented Aug 6, 2018

Thanks for figuring it out.

Please tell me what to change to make it legal!

@tbeu
Copy link
Contributor

tbeu commented Aug 6, 2018 •
edited
Loading

Documentation of Testing.Runners.checkPackage prints that classes with the annotation __Dymola_interactive=true are skipped. Could this be a solution for the Testing issue?

@hyumo
Copy link
Author

hyumo commented Aug 6, 2018

Yes, for sure.

tbeu added a commit that referenced this issue Aug 6, 2018
@tbeu @overtaker
refs #28: Set interactive flag for member functions to exclude from D…
280cda6 
…ymola check
tbeu added a commit that referenced this issue Aug 6, 2018
@tbeu
refs #28: Set interactive flag for member functions to exclude from D…
029f8a6 
…ymola check
tbeu added a commit that referenced this issue Aug 6, 2018
@tbeu
refs #28: Set interactive flag for member functions to exclude from D…
486e62d 
…ymola check

[ci skip]
@tbeu
Copy link
Contributor

tbeu commented Aug 6, 2018

OK, check again then.

@hyumo
Copy link
Author

hyumo commented Aug 6, 2018

Thanks for the fix. All passed.

> Checking all classes in ExternData
(i) started at 2018-8-6 16:00:21
(i) pedantic check is off
(i) found 160 classes
  #ok: ExternData.UsersGuide.References
  #ok: ExternData.UsersGuide.License
  #ok: ExternData.UsersGuide.Contact
  #ok: ExternData.Examples.CSVTest
  #ok: ExternData.Examples.INITest
  #ok: ExternData.Examples.JSONTest
  #ok: ExternData.Examples.MATTest
  #ok: ExternData.Examples.XLSTest
  #ok: ExternData.Examples.XLSTest.computeColSum
  #ok: ExternData.Examples.XLSXTest
  #ok: ExternData.Examples.XLSXTest.computeColSum
  #ok: ExternData.Examples.XMLTest
  #ok: ExternData.Examples.TIRTest
  #ok: ExternData.CSVFile
#skip:ExternData.CSVFile.getRealArray2D (__Dymola_interactive=true)
#skip:ExternData.CSVFile.getArraySize2D (__Dymola_interactive=true)
#skip:ExternData.CSVFile.getArrayRows2D (__Dymola_interactive=true)
#skip:ExternData.CSVFile.getArrayColumns2D (__Dymola_interactive=true)
  #ok: ExternData.INIFile
#skip:ExternData.INIFile.getReal (__Dymola_interactive=true)
#skip:ExternData.INIFile.getInteger (__Dymola_interactive=true)
#skip:ExternData.INIFile.getBoolean (__Dymola_interactive=true)
#skip:ExternData.INIFile.getString (__Dymola_interactive=true)
  #ok: ExternData.JSONFile
#skip:ExternData.JSONFile.getReal (__Dymola_interactive=true)
#skip:ExternData.JSONFile.getRealArray1D (__Dymola_interactive=true)
#skip:ExternData.JSONFile.getRealArray2D (__Dymola_interactive=true)
#skip:ExternData.JSONFile.getInteger (__Dymola_interactive=true)
#skip:ExternData.JSONFile.getIntegerArray1D (__Dymola_interactive=true)
#skip:ExternData.JSONFile.getIntegerArray2D (__Dymola_interactive=true)
#skip:ExternData.JSONFile.getBoolean (__Dymola_interactive=true)
#skip:ExternData.JSONFile.getBooleanArray1D (__Dymola_interactive=true)
#skip:ExternData.JSONFile.getBooleanArray2D (__Dymola_interactive=true)
#skip:ExternData.JSONFile.getString (__Dymola_interactive=true)
#skip:ExternData.JSONFile.getStringArray1D (__Dymola_interactive=true)
#skip:ExternData.JSONFile.getStringArray2D (__Dymola_interactive=true)
#skip:ExternData.JSONFile.getArraySize1D (__Dymola_interactive=true)
#skip:ExternData.JSONFile.getArraySize2D (__Dymola_interactive=true)
#skip:ExternData.JSONFile.getArrayRows2D (__Dymola_interactive=true)
#skip:ExternData.JSONFile.getArrayColumns2D (__Dymola_interactive=true)
  #ok: ExternData.MATFile
#skip:ExternData.MATFile.getRealArray2D (__Dymola_interactive=true)
#skip:ExternData.MATFile.getStringArray1D (__Dymola_interactive=true)
#skip:ExternData.MATFile.getArraySize2D (__Dymola_interactive=true)
#skip:ExternData.MATFile.getArrayRows2D (__Dymola_interactive=true)
#skip:ExternData.MATFile.getArrayColumns2D (__Dymola_interactive=true)
  #ok: ExternData.XLSFile
#skip:ExternData.XLSFile.getReal (__Dymola_interactive=true)
#skip:ExternData.XLSFile.getRealArray2D (__Dymola_interactive=true)
#skip:ExternData.XLSFile.getInteger (__Dymola_interactive=true)
#skip:ExternData.XLSFile.getBoolean (__Dymola_interactive=true)
#skip:ExternData.XLSFile.getString (__Dymola_interactive=true)
#skip:ExternData.XLSFile.getArraySize2D (__Dymola_interactive=true)
#skip:ExternData.XLSFile.getArrayRows2D (__Dymola_interactive=true)
#skip:ExternData.XLSFile.getArrayColumns2D (__Dymola_interactive=true)
  #ok: ExternData.XLSXFile
#skip:ExternData.XLSXFile.getReal (__Dymola_interactive=true)
#skip:ExternData.XLSXFile.getRealArray2D (__Dymola_interactive=true)
#skip:ExternData.XLSXFile.getInteger (__Dymola_interactive=true)
#skip:ExternData.XLSXFile.getBoolean (__Dymola_interactive=true)
#skip:ExternData.XLSXFile.getString (__Dymola_interactive=true)
#skip:ExternData.XLSXFile.getArraySize2D (__Dymola_interactive=true)
#skip:ExternData.XLSXFile.getArrayRows2D (__Dymola_interactive=true)
#skip:ExternData.XLSXFile.getArrayColumns2D (__Dymola_interactive=true)
  #ok: ExternData.XMLFile
#skip:ExternData.XMLFile.getReal (__Dymola_interactive=true)
#skip:ExternData.XMLFile.getRealArray1D (__Dymola_interactive=true)
#skip:ExternData.XMLFile.getRealArray2D (__Dymola_interactive=true)
#skip:ExternData.XMLFile.getInteger (__Dymola_interactive=true)
#skip:ExternData.XMLFile.getBoolean (__Dymola_interactive=true)
#skip:ExternData.XMLFile.getString (__Dymola_interactive=true)
#skip:ExternData.XMLFile.getArraySize1D (__Dymola_interactive=true)
#skip:ExternData.XMLFile.getArraySize2D (__Dymola_interactive=true)
#skip:ExternData.XMLFile.getArrayRows2D (__Dymola_interactive=true)
#skip:ExternData.XMLFile.getArrayColumns2D (__Dymola_interactive=true)
  #ok: ExternData.TIRFile
#skip:ExternData.TIRFile.getReal (__Dymola_interactive=true)
#skip:ExternData.TIRFile.getInteger (__Dymola_interactive=true)
#skip:ExternData.TIRFile.getBoolean (__Dymola_interactive=true)
#skip:ExternData.TIRFile.getString (__Dymola_interactive=true)
  #ok: ExternData.Functions.CSV.getRealArray2D
  #ok: ExternData.Functions.CSV.getArraySize2D
  #ok: ExternData.Functions.CSV.getArrayRows2D
  #ok: ExternData.Functions.CSV.getArrayColumns2D
  #ok: ExternData.Functions.INI.getReal
  #ok: ExternData.Functions.INI.getInteger
  #ok: ExternData.Functions.INI.getBoolean
  #ok: ExternData.Functions.INI.getString
  #ok: ExternData.Functions.JSON.getReal
  #ok: ExternData.Functions.JSON.getRealArray1D
  #ok: ExternData.Functions.JSON.getRealArray2D
  #ok: ExternData.Functions.JSON.getInteger
  #ok: ExternData.Functions.JSON.getIntegerArray1D
  #ok: ExternData.Functions.JSON.getIntegerArray2D
  #ok: ExternData.Functions.JSON.getBoolean
  #ok: ExternData.Functions.JSON.getBooleanArray1D
  #ok: ExternData.Functions.JSON.getBooleanArray2D
  #ok: ExternData.Functions.JSON.getString
  #ok: ExternData.Functions.JSON.getStringArray1D
  #ok: ExternData.Functions.JSON.getStringArray2D
  #ok: ExternData.Functions.JSON.getArraySize1D
  #ok: ExternData.Functions.JSON.getArraySize2D
  #ok: ExternData.Functions.JSON.getArrayRows2D
  #ok: ExternData.Functions.JSON.getArrayColumns2D
  #ok: ExternData.Functions.MAT.getRealArray2D
  #ok: ExternData.Functions.MAT.getStringArray1D
  #ok: ExternData.Functions.MAT.getArraySize2D
  #ok: ExternData.Functions.MAT.getArrayRows2D
  #ok: ExternData.Functions.MAT.getArrayColumns2D
  #ok: ExternData.Functions.XLS.getReal
  #ok: ExternData.Functions.XLS.getRealArray2D
  #ok: ExternData.Functions.XLS.getInteger
  #ok: ExternData.Functions.XLS.getBoolean
  #ok: ExternData.Functions.XLS.getString
  #ok: ExternData.Functions.XLS.getArraySize2D
  #ok: ExternData.Functions.XLS.getArrayRows2D
  #ok: ExternData.Functions.XLS.getArrayColumns2D
  #ok: ExternData.Functions.XLSX.getReal
  #ok: ExternData.Functions.XLSX.getRealArray2D
  #ok: ExternData.Functions.XLSX.getInteger
  #ok: ExternData.Functions.XLSX.getBoolean
  #ok: ExternData.Functions.XLSX.getString
  #ok: ExternData.Functions.XLSX.getArraySize2D
  #ok: ExternData.Functions.XLSX.getArrayRows2D
  #ok: ExternData.Functions.XLSX.getArrayColumns2D
  #ok: ExternData.Functions.XML.getReal
  #ok: ExternData.Functions.XML.getRealArray1D
  #ok: ExternData.Functions.XML.getRealArray2D
  #ok: ExternData.Functions.XML.getInteger
  #ok: ExternData.Functions.XML.getBoolean
  #ok: ExternData.Functions.XML.getString
  #ok: ExternData.Functions.XML.getArraySize1D
  #ok: ExternData.Functions.XML.getArraySize2D
  #ok: ExternData.Functions.XML.getArrayRows2D
  #ok: ExternData.Functions.XML.getArrayColumns2D
  #ok: ExternData.Interfaces.partialGetReal
  #ok: ExternData.Interfaces.partialGetInteger
  #ok: ExternData.Interfaces.partialGetBoolean
  #ok: ExternData.Interfaces.partialGetString
  #ok: ExternData.Types.ExternCSVFile
  #ok: ExternData.Types.ExternCSVFile.constructor
  #ok: ExternData.Types.ExternCSVFile.destructor
  #ok: ExternData.Types.ExternINIFile
  #ok: ExternData.Types.ExternINIFile.constructor
  #ok: ExternData.Types.ExternINIFile.destructor
  #ok: ExternData.Types.ExternJSONFile
  #ok: ExternData.Types.ExternJSONFile.constructor
  #ok: ExternData.Types.ExternJSONFile.destructor
  #ok: ExternData.Types.ExternMATFile
  #ok: ExternData.Types.ExternMATFile.constructor
  #ok: ExternData.Types.ExternMATFile.destructor
  #ok: ExternData.Types.ExternXLSFile
  #ok: ExternData.Types.ExternXLSFile.constructor
  #ok: ExternData.Types.ExternXLSFile.destructor
  #ok: ExternData.Types.ExternXLSXFile
  #ok: ExternData.Types.ExternXLSXFile.constructor
  #ok: ExternData.Types.ExternXLSXFile.destructor
  #ok: ExternData.Types.ExternXMLFile
  #ok: ExternData.Types.ExternXMLFile.constructor
  #ok: ExternData.Types.ExternXMLFile.destructor
(i) check finished at 2018-8-6 16:00:43
(i) required time: 0d 0h 0min 22s 322ms
(i) Summary
  160 classes
  101 ok
    0 fail
   59 skipped

@tbeu tbeu closed this as completed Aug 6, 2018
@hyumo
Copy link
Author

hyumo commented Aug 7, 2018

I've made an example of CSV reader

https://github.com/hyumo/CSVReader

@tbeu
Copy link
Contributor

tbeu commented Aug 7, 2018

I've made an example of CSV reader

Nice demonstration. Thanks a lot! I will adapt ExternData to your proposed structure though OpenModelica still gives the same "cyclic dependency" error.

@tbeu tbeu reopened this Aug 7, 2018
@hyumo
Copy link
Author

hyumo commented Aug 7, 2018

I tried different things in OpenModelica too, but none of them works. It's giving me different errors, but only one is consistent: Not being able to find the constructed csv object etc.

I'll keep trying, I am not a fan of passing the filename and constructor settings to each function. Actually, I should say I don't know if it calls the constructor function for each any every getXXX methods during initialization, this will be a big performance hit. Does the current fix for openmodelica constructs a reader object in each get method?

@tbeu
Copy link
Contributor

tbeu commented Aug 7, 2018

See also omc:#4448 regarding ExternData in OpenModelica.

overtaker added a commit that referenced this issue Aug 8, 2018
@overtaker
refs #28: Set interactive flag for member functions to exclude from D…
8b62794 
…ymola check

[ci skip]
overtaker added a commit that referenced this issue Aug 10, 2018
@overtaker
refs #28: Restructure functions
68427e7 
[ci skip]
overtaker added a commit that referenced this issue Aug 16, 2018
@overtaker
refs #28: Declare interface functions as partial
8676322 
[ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tbeu @hyumo @overtaker