-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add msys2/mingw CI build for the external libraries #37
Add msys2/mingw CI build for the external libraries #37
Conversation
Thanks for the PR. As libexpat was updated by (8a68ebd) I'd like to ask you if you could add a Appveyor CI to build the mingw32/64 libs there. Having it as integrated CI would be of greater value than just updating the libs occasionally. Thanks again. |
Sure. I don't have too much experience with Appveyor CI but I'll see what I can do. |
I think I can provide teh initial setup. Would be good to have it before end of month such that i can update the MoCo paper. Thanks. |
I will try using msys2 package as explained here: https://docs.travis-ci.com/user/reference/windows/#how-do-i-use-msys2. |
Initial setup might be tricky: Have a look at https://github.com/tbeu/matio/blob/master/.appveyor.yml#L133 |
Please rebase your branch on current master and note that libED_SSVFile was replaced by libED_XML2File with new dependency on libxml2. Thanks. |
295dc12
to
1853949
Compare
This needs more work but I will keep working on in. |
4e7e99b
to
b5a8cc7
Compare
- enable just the windows build for now until it works - put the commands in a file to get proper errors - add a lot of echo to understand where it goes wrong - install more packages and both 32bit/64bit ones
b5a8cc7
to
b358576
Compare
At least it builds now, I'll clean it up tomorrow or so and then request a review. |
@adrpo I am going to release v3.0.0 latest by Friday (30/7) night. Would be good to have your build script CI merged. Thanks. |
Agreed, will play with it tomorrow. |
Some issues with paths (tar and upload). |
Can we put the binaries to Library/win32/gcc810 and Library/win64/gcc810 which would be compliant with MLS 3.4? |
Seems to be OK with the spec: https://specification.modelica.org/maint/3.5/functions.html#annotations-for-external-libraries-and-include-files |
I can try with symlinks. |
I think I found what the problem is, the build is building in a specific directory and the upload script is called from the top level, will fix it. |
You already fixed it, I have some other way of fixing it without the cd, basically using the path to the upload file: Should I push my change or just leave yours? |
Hang on, I am about to fix it. |
Ok. Let me know if you need anything more. |
Note that you cannot do:
as each command starts from the top again, it has no previous context, so do:
|
Can we use cmd or ps1 from https://bitbucket.org/swyter/bitbucket-curl-upload-to-repo-downloads/src/default/ for the uploads as it gives syntax errors otherwise? |
Here's my current setup: https://github.com/modelica-3rdparty/ExternData/tree/AddMinGWOpenModelicaLibs |
Sorry, I cancelled your build as we will run out of credits to soon then. |
No problem. I will check on my computer if is works fine on my local mingw. |
With the latest changes it seems to be working fine on my computer. You can try to run it again tomorrow, sorry I had so many tentative changes, is hard to test properly otherwise. |
86cfde4
to
01e6925
Compare
37697ec
to
65cecd5
Compare
65cecd5
to
f119903
Compare
It still gives "error: missing arguments :(" when uploading. I have no more clue, |
All merged. Thanks a lot! |
This PR adds a CI build for the external libraries on mingw. [It previously just added the binaries directly].
Partially fixes #29.