Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give a proper definition of machine constants. #4042

Merged
merged 3 commits into from
Jun 15, 2023

Conversation

HansOlsson
Copy link
Contributor

They are compatible with text in the C-standard (so one can use DBL_EPS, DBL_MIN and DBL_MAX), and usable in practice.
Closes #2056

They are compatible with C, and usable.
Closes modelica#2056
@HansOlsson HansOlsson added bug Critical/severe issue L: Constants Issue addresses Modelica.Constants labels Sep 30, 2022
Copy link
Member

@beutlich beutlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the strings and values in ModelicaServices.Machine need to be adapted, too.

@HansOlsson
Copy link
Contributor Author

I guess the strings and values in ModelicaServices.Machine need to be adapted, too.

The strings obviously.
The values - ideally yes, but that may break things in some bad models in MSL; thus it might be better to delay that if necessary.

@beutlich
Copy link
Member

The values - ideally yes, but that may break things in some bad models in MSL; thus it might be better to delay that if necessary.

Yes, this might be the case and can be figured out during regression testing for a new MSL release. Otherwise, the description strings and the old values do not match. Thus, I am in favour to change both values and strings.

@beutlich beutlich self-requested a review September 30, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical/severe issue L: Constants Issue addresses Modelica.Constants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proper definition of Modelica.Constants.{eps,small}
5 participants