-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give a proper definition of machine constants. #4042
Give a proper definition of machine constants. #4042
Conversation
They are compatible with C, and usable. Closes modelica#2056
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the strings and values in ModelicaServices.Machine need to be adapted, too.
The strings obviously. |
Yes, this might be the case and can be figured out during regression testing for a new MSL release. Otherwise, the description strings and the old values do not match. Thus, I am in favour to change both values and strings. |
They are compatible with text in the C-standard (so one can use DBL_EPS, DBL_MIN and DBL_MAX), and usable in practice.
Closes #2056