-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mustBeConnected annotation (introduced in Modelica 3.6) #4204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onditional support connectors.
HansOlsson
added
L: Mechanics.Rotational
Issue addresses Modelica.Mechanics.Rotational
L: Mechanics.Translational
Issue addresses Modelica.Mechanics.Translational
labels
Oct 17, 2023
beutlich
added
the
requires Modelica 3.6
Issue that requires Modelica Language Specification 3.6
label
Oct 18, 2023
tobolar
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This was referenced Nov 6, 2023
dietmarw
force-pushed
the
MustBeConnected
branch
from
December 13, 2023 10:47
ced52be
to
262044f
Compare
MartinOtter
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
L: Mechanics.Rotational
Issue addresses Modelica.Mechanics.Rotational
L: Mechanics.Translational
Issue addresses Modelica.Mechanics.Translational
requires Modelica 3.6
Issue that requires Modelica Language Specification 3.6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for all conditional support connectors in Rotational and Translational; based on decision in #4175
See "Modelica 3.6 - Changes, Benefits and Implementation" by Hans Olsson, from Modelica Conference 2023, https://www.conftool.com/modelica2023/index.php?page=browseSessions&form_session=34
In Dymola 2024x the library should still work after the change, but if you introduce an unconnected support connector in a model it will fail, e.g.: