Demonstrate PolyphaseInitialization#4718
Conversation
henrikt-ma
left a comment
There was a problem hiding this comment.
Sorry, I don't know enough about polyphase inductor currents to review this without further guidance about what to keep an eye on.
|
@henrikt-ma is not a question on correct initialization, but on conformity to standard and usability, |
maltelenz
left a comment
There was a problem hiding this comment.
It would be really nice if a figure could be added as well!
Modelica/Electrical/Polyphase/Examples/PolyphaseInitialization.mo
Outdated
Show resolved
Hide resolved
Modelica/Electrical/Polyphase/Examples/PolyphaseInitialization.mo
Outdated
Show resolved
Hide resolved
Modelica/Electrical/Polyphase/Examples/PolyphaseInitialization.mo
Outdated
Show resolved
Hide resolved
Modelica/Electrical/Polyphase/Examples/PolyphaseInitialization.mo
Outdated
Show resolved
Hide resolved
Co-authored-by: Malte Lenz <malte.lenz@gmail.com>
Co-authored-by: Malte Lenz <malte.lenz@gmail.com>
Co-authored-by: Malte Lenz <malte.lenz@gmail.com>
Do you mean in the example? The diagramm layer acts as the figure. Should I draw a nicer one? |
I meant a figure in the sense of the |
This example is more about "How is initialization of a polyphase system done?" and not so much about the results. |
|
I guess plotting the variables that were initialized makes sense? After getting used to having ready-made plots available for most examples I encounter (System Modeler has had figures for a long time, and we routinely add them to any models we build), arriving in the simulation environment with just a mass of variables and having to start digging for what to plot, has become somewhat of a shock :) |
Modelica/Electrical/Polyphase/Examples/PolyphaseInitialization.mo
Outdated
Show resolved
Hide resolved
HansOlsson
left a comment
There was a problem hiding this comment.
Apart from the minor note it looks good.
I very much agree and I hope @AHaumer agrees as well Co-authored-by: Hans Olsson <HansOlsson@users.noreply.github.com>
christiankral
left a comment
There was a problem hiding this comment.
The proposal looks good to me
Addresses #4457 to have an explanation and an example how polyphase initialiuation is implemented.