Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error if :page-index: is out of bounds with tests #16

Closed
modelmat opened this issue Apr 7, 2020 · 1 comment · Fixed by #82
Closed

Error if :page-index: is out of bounds with tests #16

modelmat opened this issue Apr 7, 2020 · 1 comment · Fixed by #82
Labels
bug Something isn't working

Comments

@modelmat
Copy link
Owner

modelmat commented Apr 7, 2020 •
edited
Loading

If :page-index: is outside of the number of pages in the document, it should raise an error. Currently, it falls back to the first page

EDIT: appears it falls back to the last page
@modelmat
Copy link
Owner Author

modelmat commented Apr 12, 2020 •
edited
Loading

This isn't possible as this is an issue on the drawio-desktop backend. An issue probably should be created.

EDIT 17/09: I haven't done this yet and don't have a dev environment setup. Hopefully, I can file the issue soon.

@modelmat modelmat added the bug Something isn't working label Sep 17, 2020
@modelmat modelmat changed the title Add test for error handling associated with :page-index: or other options Error if :page-index: is out of bounds with tests Sep 17, 2020
@schspa schspa mentioned this issue Dec 20, 2022
Merged
@modelmat modelmat mentioned this issue Dec 21, 2022
Merged
modelmat added a commit that referenced this issue Dec 21, 2022
@modelmat
Produce a warning if the supplied :page-index: is outside the valid r…
def6f5a 
…ange (#82)

Fixes #16

Only a warning is produced as this may not be valid across new versions of draw.io if the internal XML format changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@modelmat