Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add returncode to subprocess.CalledProcessError output #70

Merged
merged 2 commits into from
May 10, 2022

Conversation

jdillard
Copy link
Collaborator

@jdillard jdillard commented May 9, 2022

This is for slightly better output as discussed in #69. It appears not all return codes have stderr output associated with them, so this will help in those rare cases.

Apparently there are ways to get more information about the return code, such as this line in subprocess.py, but I didn't know how finicky that would be and I left it as the bare return code.

Fixes #69

@modelmat
Copy link
Owner

@jdillard Looks like the line length is too long so if you can fix that I'll merge this.

@jdillard
Copy link
Collaborator Author

Oops! I think I got it right this time.

@modelmat modelmat merged commit 7ef3a40 into modelmat:master May 10, 2022
@modelmat
Copy link
Owner

Now to figure out how to push a release... I've forgotten.

@jdillard
Copy link
Collaborator Author

Ha I know the feeling! I have to put a MAINTENANCE.md file in my projects with instructions for myself so I don't forget (there is probably a better way though).

@modelmat
Copy link
Owner

modelmat commented May 10, 2022

Should be released now. Ignore the fact CI says it failed to release, it seems to upload it twice for unknown reason and then fail the second.

@jdillard
Copy link
Collaborator Author

I see it https://pypi.org/project/sphinxcontrib-drawio/. You rock! Thanks so much!

@jdillard jdillard deleted the patch-2 branch March 20, 2023 21:17
@jdillard jdillard restored the patch-2 branch August 14, 2023 17:28
@jdillard jdillard deleted the patch-2 branch August 14, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting random failures that have an empty stderr/stdout
2 participants