Rework conversion handling to prevent subtle errors #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error on invalid formats for both global & local config, for the drawio valid formats and valid builder formats. Changes imgconverter tests to verify no unnecessary conversions and no erroring when using that extension.
modelmat
force-pushed
the
better-conversion-handling
branch
from
5a7bab2 to
67f13b2
Compare
modelmat
added a commit
that referenced
this pull request
Dec 21, 2022
Fixes #63 Error on invalid formats for both global & local config, for the drawio valid formats and valid builder formats. Changes imgconverter tests to verify no unnecessary conversions and no erroring when using that extension.
modelmat
added a commit
that referenced
this pull request
Dec 21, 2022
Fixes #63 Error on invalid formats for both global & local config, for the drawio valid formats and valid builder formats. Changes imgconverter tests to verify no unnecessary conversions and no erroring when using that extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63
Error on invalid formats for both global & local config, for the drawio valid formats and valid builder formats.
Changes imgconverter tests to verify no unnecessary conversions and no erroring when using that extension.