Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sentencepiece tokenization for minhash deduplicator #269

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Add sentencepiece tokenization for minhash deduplicator #269

merged 1 commit into from
Mar 21, 2024

Conversation

pan-x-c
Copy link
Collaborator

@pan-x-c pan-x-c commented Mar 21, 2024

  1. Add sentencepiece tokenization for minhash deduplicator
  2. Fix redis dependency not found error

@pan-x-c pan-x-c added bug Something isn't working enhancement New feature or request labels Mar 21, 2024
@pan-x-c pan-x-c requested review from yxdyc and HYLcool March 21, 2024 06:45
HYLcool
HYLcool approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@HYLcool HYLcool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pan-x-c pan-x-c merged commit 4dd8561 into main Mar 21, 2024
2 checks passed
@HYLcool HYLcool deleted the feature/pxc/tokenizer_for_minhash branch December 23, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HYLcool HYLcool HYLcool approved these changes

@yxdyc yxdyc Awaiting requested review from yxdyc

Assignees

@pan-x-c pan-x-c

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pan-x-c @HYLcool