Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Updates serialization to use MMF (considerable memory savings) #1841

Merged
merged 4 commits into from
Jun 23, 2024
Merged

feat: Updates serialization to use MMF (considerable memory savings) #1841

merged 4 commits into from
Jun 23, 2024

Conversation

kamronbatman
Copy link
Contributor

@kamronbatman kamronbatman commented Jun 19, 2024 •
edited
Loading

Summary

Updates the serialization strategy to use MemoryMappedFile instead of thick buffers. This has the benefit of being on-par with the current implementation (based on hardware/OS), however won't incur the double-memory issue.

Important

Developer Note
The BinaryFileWriter and BinaryFileReader has been removed in favor of MemoryMapFileWriter and UnmanagedDataReader

@kamronbatman kamronbatman force-pushed the kbatman/mmf_serialization branch 3 times, most recently from f960525 to 26d60c8 Compare June 20, 2024 05:56
@kamronbatman kamronbatman changed the title feat: Updates serialization to use MMF feat: Updates serialization to use MMF (considerable memory savings) Jun 22, 2024
@kamronbatman kamronbatman merged commit 8ec203f into main Jun 23, 2024
11 of 12 checks passed
@kamronbatman kamronbatman deleted the kbatman/mmf_serialization branch June 23, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kamronbatman