Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes Lich Lord minions from attacking their master and each other #2051

Closed
wants to merge 4 commits into from

Conversation

Bohicatv
Copy link
Contributor

@Bohicatv Bohicatv commented Jan 3, 2025

No description provided.

@kamronbatman
Copy link
Contributor

I think I fixed this already recently. Can you double check before we decide on this PR?

@Bohicatv
Copy link
Contributor Author

Bohicatv commented Jan 3, 2025

I got reports that it was still bugged yesterday afternoon. I tested and was able to reproduce it yesterday. This PR will fix it in its entirety.

@kamronbatman
Copy link
Contributor

kamronbatman commented Jan 3, 2025

I got reports that it was still bugged yesterday afternoon. I tested and was able to reproduce it yesterday. This PR will fix it in its entirety.

It doesn't fix the problem generally though. So it might be better to fix IsEnemy (again, sigh)

@Bohicatv
Copy link
Contributor Author

Bohicatv commented Jan 3, 2025

You're right, but I thought both PRs were needed since you did an attempt to fix it recently.

@Bohicatv Bohicatv closed this Jan 15, 2025
@Bohicatv Bohicatv deleted the patch-8 branch January 15, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants